Module Publication: fix the way to handle docker image information #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results219 tests ±0 212 ✅ - 6 1m 44s ⏱️ +2s For more details on these failures, see this check. Results for commit 337b199. ± Comparison against base commit 87e1b2b. |
Darkheir
reviewed
Nov 4, 2024
| if docker := manifest.get("docker"): | ||
| return docker | ||
| (name, version, *extra) = docker.split(":") | ||
| return DockerInfo(name, version) |
There was a problem hiding this comment.
Do we have manifests with the docker attribute ?
Maybe we should stop supporting it since it may lead to a lot of issues:
- Registry not being set
- version in the attribute not the same as the "real" module version
There was a problem hiding this comment.
I took in account your comment with this PR
|
Closed in favor of #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker image can be got from the module of the manifest or computed.
However, according to the way the docker image is got, the value can be inconsistent. I changed the way to represent the docker image information to always get the right information.